This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: show error if library cannot be connected #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marionebl
reviewed
Jun 10, 2018
src/electron/main.ts
Outdated
| library.assignPropertyId(patternId, contextId), | ||
| getGlobalSlotId: (patternId, contextId) => library.assignSlotId(patternId, contextId) | ||
| }); | ||
| let analysis; |
There was a problem hiding this comment.
Let's avoid the let binding by defining a getAnalysis function that returns a AnalysisResult:
type AnalysisResult =
| AnalysisError
| AnalysisSuccess;
enum AnalysisState {
Error,
Success
}
interface AnalysisError {
state: AnalysisState.Error;
error: Error;
}
interface AnalysisSuccess {
state: AnalysisState.Success;
analysis: Analysis;
}
const getAnalysis = async (path: string; context: AnalysisContext): Promise<AnalysisResult> => {
try {
return { state: AnalysisState.Sucess, analysis: Analyzer.analyze(path, context) };
} catch (error) {
return { state: AnalysisState.Error, error };
}
};This can be used like this then:
const analysisResult = await getAnalysis(/* omitted */);
if (analysisResult.state === AnalysisState.Success) {
// send
}
if (analysisResult.state === AnalysisState.Error) {
// show dialog
}
tilmx
changed the title
|
@marionebl I changed it to try both the analysis and the Sender.Send to avoid any |
tilmx
changed the title
marionebl
approved these changes
Jun 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user tries to connect a library folder that does not work, we should give him a warning about that.
should be squashed into
feat: show error if library cannot be connected